Updating versioneer again, properly. #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtristan
requested review from
juergbi,
BenjaminSchubert,
cs-shadow and
abderrahim
as code owners
First time around we were using `versioneer install --no-vendor`, and neglecting to remove the `versioneer.py` file from the toplevel, which is still required by BuildStream's setup.py for a few reasons. Instead, go back to `versioneer install --vendor` and update versioneer files correctly. Fixes #1855
gtristan
force-pushed
the
tristan/update-versioneer
branch
from
0e88500
to
cf7ff12
Compare
Callek
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time around we were using
versioneer install --no-vendor, and neglecting to remove theversioneer.pyfile from the toplevel, which is still required by BuildStream's setup.py for a few reasons.Instead, go back to
versioneer install --vendorand update versioneer files correctly.Fixes #1855